test(dev-server): support UI port #1273
Open
+35
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tconley1428
reviewed
Jan 16, 2026
| ui_port_str = str(dev_server_ui_port) | ||
| extra_args_list = list(dev_server_extra_args) | ||
| if "--ui-port" not in extra_args_list: | ||
| # Prepend to extra_args so user-provided args can override if needed |
Contributor
There was a problem hiding this comment.
This comment is odd. You explicitly only even append the argument if it won't be overridden. I would either remove the comment or allow the argument to always be appended
tconley1428
requested changes
Jan 16, 2026
Contributor
tconley1428
left a comment
tconley1428
left a comment
There was a problem hiding this comment.
There are a number of linting errors which would need to be fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added
dev_server_ui_portparameter toWorkflowEnvironment.start_local()method to allow users to customize the UI port when starting a local Temporal dev server environment.Why?
This feature allows users to specify a custom UI port when starting the dev server
Checklist
Closes [Feature Request] Allow customization of dev server UI port #748
How was this tested:
Any docs updates needed?
start_local()method